-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC Remove filterwarnings
from some examples
#766
Comments
filterwarnings
from some examplesfilterwarnings
from some examples
https://github.com/skrub-data/skrub/blob/main/skrub/_fuzzy_join.py#L359 If it warns whenever used, probably it's bad idea to remove |
There is also warning in https://skrub-data.org/stable/auto_examples/02_investigating_dirty_categories.html I can fix it if necessary. |
Indeed, we plan to remove |
That would be great, you can go ahead and create a PR! |
Hi guys, I'm hoping to try and fix these warnings in example 3 and 4 |
Hey @dcor01, example 3 is already solved, but you can focus on example 4. |
I have made a pull request let me know your thoughts. #807 I also made a few capitalisation changes in example 4. |
Changed the filter warnings in example 4 in #808 |
1 similar comment
Changed the filter warnings in example 4 in #808 |
Describe the issue linked to the documentation
Some examples filter all warnings, but we want those for debugging, catching deprecation, and getting closer to the user reality.
We need to remove
warnings.filterwarnings("ignore")
—and fix the potential warnings— from the following files:03_datetime_encoder.py
04_fuzzy_joining.py
Suggest a potential alternative/fix
No response
The text was updated successfully, but these errors were encountered: