PR - issue766 - Fixed the ignore warnings for example 04_fuzzy_joining #807
Conversation
| @@ -253,8 +248,8 @@ | |||
| y="Happiness score", | |||
| lowess=True, | |||
| ) | |||
| fig.set_ylabel("Happiness index") | |||
There was a problem hiding this comment.
thanks for the fix! the figure title changes don't seem related to filtering warnings, right?
I think the old title might easier to understand for some readers, because "effect" could be understood to imply that life expectancy has a causal effect on happiness
| fig.set_ylabel("Happiness index") | ||
| fig.set_title("Does a country's legal rights strength lead to happiness?") | ||
| fig.set_ylabel("Happiness Index") | ||
| fig.set_title("Effect of a Country's Strength of Legal Rights on Happiness") |
There was a problem hiding this comment.
if we're changing the title I rather like the "is x linked to y" formulation above because it is more clear that we are only talking about correlations
There was a problem hiding this comment.
Yeah fair enough. I will delete the wording changes. I just thought a question as a graph title looked a bit strange but happy to just leave them as is.
|
I will close this PR. Instead using #808 without the wording changes |
Working towards issue #766
I have removed the warning thrown everytime fuzzy_join() is called. I have also got rid of the warnings.filterwarnings("ignore") in example 4.
I have also changed a few of the titles and capitalisation in example 4 that I noticed. Happy to remove them and resubmit the pull request if you guys don't like them.
Let me know your thoughts - this is my first PR. Thanks guys