Improve SuperVectorizer#201
Merged
alexis-cvetkov merged 27 commits intoOct 8, 2021
Merged
Conversation
20b8d79 to
85aa2a4
Compare
Member
Author
|
Updated original comment to describe the changes of d5f6193 |
GaelVaroquaux
left a comment
Member
There was a problem hiding this comment.
Partial review. I'll finish this ASAP
GaelVaroquaux
left a comment
Member
There was a problem hiding this comment.
OK, I finished going through all the code, and I put in all my comments. This PR will be good to go.
Member
|
For standard keywords, yes, but not for type hinted ones.
Thank you for correcting me. My knowledge is getting too old :)
|
3d506f1 to
651824d
Compare
Contributor
|
I finished reviewing the PR:
|
Member
|
The questions of Alexis are very relevant. Once they are addressed, I am +1 for merge. |
Member
Author
|
Alexis' questions are addressed by the last commits, thanks for the feedback ! |
Contributor
|
Merging ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements various improvements in the SuperVectorizer, such as :