ENH Added test of analyzer and corrected the gap encoder options #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaelVaroquaux
requested changes
Mar 18, 2022
|
Done. |
GaelVaroquaux
approved these changes
Mar 18, 2022
jovan-stojanovic
changed the title
jovan-stojanovic
changed the title
jovan-stojanovic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @GaelVaroquaux, we noticed that the output of the gap encoder was identical when the parameter analyzer = "word" or analyzer = "char". This is not possible as the encoding method should be different.
A test was added to test_gap_encoder.py to ensure that this is no longer possible.
Line 580 was missing the analyzer parameter which created the problem of identical outputs.
Finally, the Hashing Vectorizor on line 864 didn't take into account the change of the analyzer parameter, but always stayed "char", is this normal?
Thanks!