Remove warnings created by version checks #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not very happy about adding a requirement, I must say. Every requirement is an additional liability and amount of work for a user. |
…fix_distutil_deprecation � Conflicts: � dirty_cat/super_vectorizer.py
|
Following the previous point, I've added a little replacement class that works pretty much like the two other packages. |
|
I like the idea, but we have a lot of failing tests right now :) |
…fix_distutil_deprecation � Conflicts: � dirty_cat/gap_encoder.py � dirty_cat/similarity_encoder.py
|
Should be good now ! |
|
That's great! Thanks a lot. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #260 by replacing
distutils.version.LooseVersionbypackaging.version.Version.Therefore, it also adds
packagingto the requirements.