Skip to content

Fix SuperVectorizer's get_feature_names_out FutureWarning#262

Merged
GaelVaroquaux merged 2 commits into
skrub-data:masterfrom
LilianBoulard:fix_get_feature_names
Jun 29, 2022
Merged

Fix SuperVectorizer's get_feature_names_out FutureWarning#262
GaelVaroquaux merged 2 commits into
skrub-data:masterfrom
LilianBoulard:fix_get_feature_names

Conversation

@LilianBoulard
Copy link
Copy Markdown
Member

Continuation of #216
Fixes #259 by performing the same version check as the other occurrences.

@LilianBoulard LilianBoulard added the bug Something isn't working label Jun 8, 2022
Copy link
Copy Markdown
Member

@GaelVaroquaux GaelVaroquaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging. Thank you

@GaelVaroquaux GaelVaroquaux merged commit 7c620d8 into skrub-data:master Jun 29, 2022
@LilianBoulard LilianBoulard deleted the fix_get_feature_names branch July 5, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

missed scikit-learn api changes on get_feature_names

2 participants