Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display column names instead of indices for remainder columns in the transformers_ attribute of the SuperVectorizer #266

Merged
merged 3 commits into from
Jun 30, 2022

Conversation

LeoGrin
Copy link
Contributor

@LeoGrin LeoGrin commented Jun 29, 2022

Solves #232
Following discussion with @GaelVaroquaux in previous PR (#236), I've made the modification in the fit method of the SuperVectorizer.

…transformers_ attribute of the SuperVectorizer
Copy link
Member

@GaelVaroquaux GaelVaroquaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. That's a great feature. I made a minor suggestion.

dirty_cat/super_vectorizer.py Show resolved Hide resolved
@GaelVaroquaux GaelVaroquaux merged commit a4fe556 into skrub-data:master Jun 30, 2022
@GaelVaroquaux
Copy link
Member

Merged! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants