Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Jaro, Jaro-Winkler and Levenshtein distances #282

Merged
merged 4 commits into from
Aug 29, 2022
Merged

Drop support for Jaro, Jaro-Winkler and Levenshtein distances #282

merged 4 commits into from
Aug 29, 2022

Conversation

LilianBoulard
Copy link
Member

Resolves #226.

@LilianBoulard LilianBoulard added this to the 0.3.0 release milestone Jul 6, 2022
@LilianBoulard LilianBoulard self-assigned this Jul 6, 2022
GaelVaroquaux
GaelVaroquaux requested changes Jul 7, 2022
View reviewed changes
Copy link
Member

@GaelVaroquaux GaelVaroquaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to deprecate the similarity argument

dirty_cat/similarity_encoder.py Outdated Show resolved Hide resolved
dirty_cat/similarity_encoder.py Outdated Show resolved Hide resolved
dirty_cat/test/test_similarity_encoder.py Outdated Show resolved Hide resolved
CHANGES.rst Outdated Show resolved Hide resolved
@GaelVaroquaux
Copy link
Member

There are still place where python-levenshtein is remaining: I found one in .travis.yml, where I believe that it should be removed.

Can you "git grep levenshtein", and check all the corresponding places that they do not need to be fixed.

@LilianBoulard
Copy link
Member Author

LilianBoulard commented Jul 12, 2022 •
edited

You're right, and that's somewhat purposeful, as Travis files will be removed by #287, as we don't use them anyway.

LilianBoulard
LilianBoulard commented Aug 5, 2022
View reviewed changes
Copy link
Member Author

@LilianBoulard LilianBoulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-checked the code, looks good to me !

GaelVaroquaux
GaelVaroquaux approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@GaelVaroquaux GaelVaroquaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you

@GaelVaroquaux GaelVaroquaux merged commit 7907296 into skrub-data:master Aug 29, 2022
@LilianBoulard LilianBoulard deleted the remove_levenshtein_dep branch September 2, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaelVaroquaux GaelVaroquaux GaelVaroquaux approved these changes

Assignees

@LilianBoulard LilianBoulard

Labels
None yet
Projects
None yet
Milestone
0.3.0 release
Development

Successfully merging this pull request may close these issues.

Remove python-levenstein
2 participants
@LilianBoulard @GaelVaroquaux