Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make unnecessary API private #331

Merged
merged 8 commits into from
Sep 14, 2022
Merged

Make unnecessary API private #331

merged 8 commits into from
Sep 14, 2022

Conversation

LilianBoulard
Copy link
Member

Fixes #315

@LilianBoulard LilianBoulard added the enhancement New feature or request label Sep 7, 2022
@LilianBoulard LilianBoulard self-assigned this Sep 7, 2022
@LilianBoulard LilianBoulard marked this pull request as ready for review September 7, 2022 15:56
@LilianBoulard
Copy link
Member Author

Please ignore the diff for _fast_hash.py, I had to modify the type of line endings.
I've added the rev to the blame ignore list, so it shouldn't be a problem. Just a bit annoying for the review of this PR!

@LilianBoulard LilianBoulard added this to the 0.3.0 release milestone Sep 7, 2022
@GaelVaroquaux
Copy link
Member

This is not necessary for release 0.3. We can move it to later.

@LilianBoulard LilianBoulard removed this from the 0.3.0 release milestone Sep 7, 2022
GaelVaroquaux
GaelVaroquaux requested changes Sep 14, 2022
View reviewed changes
Copy link
Member

@GaelVaroquaux GaelVaroquaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment: VERSION.txt should not be made private

RELEASE_PROCESS.md Outdated Show resolved Hide resolved
dirty_cat/__init__.py Outdated Show resolved Hide resolved
doc/conf.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@LilianBoulard
Rename VERSION.txt & modif refs
682a0ed
@LilianBoulard
Merge branch 'master' of https://github.com/dirty-cat/dirty_cat into …
7871972 
…private_api

� Conflicts:
�	CHANGES.rst
�	RELEASE_PROCESS.md
�	build_tools/circle/list_versions.py
�	dirty_cat/_test/test_docstrings.py
�	setup.py
GaelVaroquaux
GaelVaroquaux approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@GaelVaroquaux GaelVaroquaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GaelVaroquaux GaelVaroquaux merged commit 5d1d4e3 into skrub-data:master Sep 14, 2022
@LilianBoulard LilianBoulard mentioned this pull request Sep 15, 2022
Merged
@LilianBoulard LilianBoulard deleted the private_api branch September 15, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaelVaroquaux GaelVaroquaux GaelVaroquaux approved these changes

@jovan-stojanovic jovan-stojanovic jovan-stojanovic approved these changes

Assignees

@LilianBoulard LilianBoulard

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make API private
3 participants
@LilianBoulard @GaelVaroquaux @jovan-stojanovic