Support paths as strings in public fetching API#453
Merged
LilianBoulard merged 11 commits intoFeb 17, 2023
Conversation
LilianBoulard
commented
Jan 6, 2023
LilianBoulard
commented
Member
- Adds support for paths as strings in the public fetching API
- Uses cleaner temporary directories in the fetching test
…r_in_fetching_funcs # Conflicts: # dirty_cat/datasets/_fetching.py
…r_paths_fetching # Conflicts: # CHANGES.rst # dirty_cat/datasets/_fetching.py
Closed
Member
Author
|
Changelog entry taken care of by #432 Edit: nevermind, I'll add the PR number to it |
jovan-stojanovic
left a comment
jovan-stojanovic
left a comment
Member
There was a problem hiding this comment.
It seems there is a problem with the fetch_openml function and the temporary directory where you store downloaded files..
…r_paths_fetching # Conflicts: # dirty_cat/datasets/tests/test_fetching.py
Member
|
Darn, there are test failures, and they seem related to this PR |
Member
Author
|
Yes, and it's system-specific, which is very annoying to debug... I'll try and tackle that today |
Merged
…r_paths_fetching # Conflicts: # CHANGES.rst # dirty_cat/datasets/_fetching.py # dirty_cat/datasets/tests/test_fetching.py
…r_paths_fetching
LilianBoulard
added a commit
that referenced
this pull request
Feb 17, 2023
This reverts commit 72be1af.
LilianBoulard
added a commit
that referenced
this pull request
Feb 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.