Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean signatures for cleaner calls #514

Merged
merged 9 commits into from
Jun 6, 2023
Merged

Clean signatures for cleaner calls #514

merged 9 commits into from
Jun 6, 2023

Conversation

LilianBoulard
Copy link
Member

Fixes #510

@LilianBoulard LilianBoulard added the enhancement New feature or request label Mar 1, 2023
@LilianBoulard LilianBoulard self-assigned this Mar 1, 2023
@GaelVaroquaux
Copy link
Member

I worry that this can break user code. I'd prefer to a 0.4.1 release with minor bug fixes before we do this.

@LilianBoulard
Copy link
Member Author

I agree, I've marked the issue for the 0.5.0, I'll do the same for this PR.

@LilianBoulard LilianBoulard added this to the 0.5.0 milestone Mar 3, 2023
@jovan-stojanovic
Copy link
Member

I think this is ready to be merged after resolving conflicts :)

@LilianBoulard LilianBoulard merged commit 59039c9 into skrub-data:main Jun 6, 2023
22 checks passed
@LilianBoulard LilianBoulard deleted the clean_calls branch June 6, 2023 12:40
This was referenced Jun 12, 2023
Merged
Merged
@LilianBoulard LilianBoulard mentioned this pull request Aug 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jovan-stojanovic jovan-stojanovic jovan-stojanovic approved these changes

Assignees

@LilianBoulard LilianBoulard

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

Improve call readability
3 participants
@LilianBoulard @GaelVaroquaux @jovan-stojanovic