Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH fuzzy_join takes missing values into account as in pandas.merge #522

Merged
merged 3 commits into from
Mar 13, 2023
Merged

ENH fuzzy_join takes missing values into account as in pandas.merge #522

merged 3 commits into from
Mar 13, 2023

Conversation

jovan-stojanovic
Copy link
Member

Fix #521

GaelVaroquaux
GaelVaroquaux approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@GaelVaroquaux GaelVaroquaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GaelVaroquaux GaelVaroquaux merged commit 6d5a360 into skrub-data:main Mar 13, 2023
@jovan-stojanovic jovan-stojanovic deleted the fuzzy_join_nan branch March 13, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaelVaroquaux GaelVaroquaux GaelVaroquaux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fuzzy_join should accept joining on missing values
2 participants
@jovan-stojanovic @GaelVaroquaux