Skip to content

ENH fuzzy_join takes missing values into account as in pandas.merge - #522

Merged
GaelVaroquaux merged 3 commits into
skrub-data:mainfrom
jovan-stojanovic:fuzzy_join_nan
Mar 13, 2023
Merged

ENH fuzzy_join takes missing values into account as in pandas.merge#522
GaelVaroquaux merged 3 commits into
skrub-data:mainfrom
jovan-stojanovic:fuzzy_join_nan

Conversation

@jovan-stojanovic

Copy link
Copy Markdown
Member

Fix #521

@GaelVaroquaux GaelVaroquaux left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GaelVaroquaux
GaelVaroquaux merged commit 6d5a360 into skrub-data:main Mar 13, 2023
@jovan-stojanovic
jovan-stojanovic deleted the fuzzy_join_nan branch March 13, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fuzzy_join should accept joining on missing values

2 participants