Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Add warning fuzzy join on missing values #529

Merged
merged 3 commits into from
Mar 21, 2023

Conversation

jovan-stojanovic
Copy link
Member

Completes #521

@GaelVaroquaux
Copy link
Member

You should rebase / merge with master, to avoid the failing test.

@jovan-stojanovic
Copy link
Member Author

Done, it's ready for review now.

Copy link
Member

@GaelVaroquaux GaelVaroquaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GaelVaroquaux GaelVaroquaux merged commit e3897b3 into skrub-data:main Mar 21, 2023
@GaelVaroquaux
Copy link
Member

Merged!

@jovan-stojanovic jovan-stojanovic deleted the fuzzy_join_nan_warn branch April 5, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants