Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't continue fitting in GapEncoder.transform #548

Merged
merged 4 commits into from
Apr 18, 2023
Merged

Don't continue fitting in GapEncoder.transform #548

merged 4 commits into from
Apr 18, 2023

Conversation

LilianBoulard
Copy link
Member

Fixes #188

@LilianBoulard LilianBoulard added the bug Something isn't working label Apr 18, 2023
@LilianBoulard LilianBoulard self-assigned this Apr 18, 2023
@LilianBoulard LilianBoulard added this to the 0.4.1 milestone Apr 18, 2023
@LilianBoulard LilianBoulard marked this pull request as ready for review April 18, 2023 09:32
@LilianBoulard LilianBoulard changed the title Make GapEncoder.transform deterministic Don't continue fitting in GapEncoder.transform Apr 18, 2023
jovan-stojanovic
jovan-stojanovic approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@jovan-stojanovic jovan-stojanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is as we discussed, seems fine to me for the minor release.
I think though we should double check the implications of fixing the activations H on the results later.

@LilianBoulard LilianBoulard merged commit 2947f1d into skrub-data:main Apr 18, 2023
18 checks passed
@LilianBoulard LilianBoulard deleted the gap_transform_fix branch April 18, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jovan-stojanovic jovan-stojanovic jovan-stojanovic approved these changes

Assignees

@LilianBoulard LilianBoulard

Labels
bug Something isn't working
Projects
None yet
Milestone
0.4.1
Development

Successfully merging this pull request may close these issues.

Topic labels that changes over multiple calls of get_feature_names in GapEncoder
2 participants
@LilianBoulard @jovan-stojanovic