Add built-in column-specific transformers to TableVectorizer - #583
Conversation
column_specific_transformers to TableVectorizerTableVectorizer
GaelVaroquaux
left a comment
There was a problem hiding this comment.
Very nice! A few minor comments.
One major one: we should use this in an example. Maybe by modifying an existing one
|
You have failing tests. Can you address them please |
|
Thanks for reminding me :) |
…v' into add_column_specific_transformers_tv
jovan-stojanovic
left a comment
There was a problem hiding this comment.
Thanks @LilianBoulard, nice to see this implemented :)
A few comments for the example
Vincent-Maladiere
left a comment
There was a problem hiding this comment.
Hey Lilian, here is my first round of reviews! The example looks neat, let's add the plots from the results of the grid search :)
Co-authored-by: Vincent M <maladiere.vincent@yahoo.fr> Co-authored-by: Jovan Stojanovic <62058944+jovan-stojanovic@users.noreply.github.com>
…com/LilianBoulard/skrub into add_column_specific_transformers_tv
|
The grid-search doesn't work as expected, there is something different between the |
…olumn_specific_transformers_tv
|
So the feature has been ready for a while, but this example is blocking. Since it doesn't work and needs some more work, I've put it into a temporary directory, so it's not accessible on the website, but so we don't lose the code. I'll open an issue in a few minutes to fix that. |
jovan-stojanovic
left a comment
There was a problem hiding this comment.
I agree that we need to move on, until we find a good solution for the grid search.
Add one more small test before approving this :)
Vincent-Maladiere
left a comment
There was a problem hiding this comment.
Thank you @LilianBoulard! After adding the missing test, I'm happy with this PR as-is. Let's investigate the grid-search on a different PR :)
…com/LilianBoulard/skrub into add_column_specific_transformers_tv
…olumn_specific_transformers_tv
Co-authored-by: Vincent M <maladiere.vincent@yahoo.fr>
Vincent-Maladiere
left a comment
There was a problem hiding this comment.
Let's merge once the CI is green
Fixes part of #554
As discussed in #580, adds the
column_specific_transformersparameter to theTableVectorizer.This allows this kind of functionality:
from the
TableVectorizerdirectly, with this syntax:When the assignements need to be named (e.g. for a grid-search), the user can specify a name (same syntax as the
ColumnTransformer):