fall back to pandas if no datetime format is found#587
Merged
Conversation
Vincent-Maladiere
pushed a commit
that referenced
this pull request
Jun 12, 2023
* fall back to pandas if no datetime format is found * change changelog
GaelVaroquaux
added a commit
that referenced
this pull request
Jun 12, 2023
* Quick bootstrap * misc * fix contributing link * stabilize current LP layout * add skrub banner * replace banner with the target * center feature blocks * replace banner with the pipeline * enable transparent bg for banner * add skrub banner * remove secondary sidebar * DOC: landing page is jinja, not rst (#589) * fall back to pandas if no datetime format is found (#587) * fall back to pandas if no datetime format is found * change changelog * Fix X shape in minhash_encoder docstrings (#584) * Parallelize the `GapEncoder` (#582) * Parallelize the Gap column-wise * Add changelog entry * Update skrub/_gap_encoder.py --------- Co-authored-by: Gael Varoquaux <gael.varoquaux@normalesup.org> * fix fetching params (#591) * remove index.rst * add empty but toctree index.rst --------- Co-authored-by: Gael Varoquaux <gael.varoquaux@normalesup.org> Co-authored-by: LeoGrin <45738728+LeoGrin@users.noreply.github.com> Co-authored-by: Lilian <lilian@boulard.fr> Co-authored-by: Jovan Stojanovic <62058944+jovan-stojanovic@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #555
We now fall back on
pandas.to_datetimeformat inference when we don't find a format with_infer_datetime_format. Indeed, this function relies on pandas'guess_datetime_format, which doesn't work for weirder date format, andpandas.to_datetimeusesdateutilwhenguess_datetime_formatdoesn't work.The code to catch warnings could maybe be simplified.