-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG Remove special symbols from Ken embeddings #601
BUG Remove special symbols from Ken embeddings #601
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really think that slicing the strings is faster than the replace. Please correct me if I am wrong.
Thanks, I think this is ready to be merged then. Not to confuse with #602 which maybe needs some additional work on :) |
Thanks. Maybe a small changelog entry, so as not to surprise users |
Actually now the main changes were made with #602, merging this just to update the changelog.. |
Fix #599