Skip to content

BUG Remove special symbols from Ken embeddings - #601

Merged
jovan-stojanovic merged 27 commits into
skrub-data:mainfrom
jovan-stojanovic:fix_ken_output
Jun 15, 2023
Merged

jovan-stojanovic merged 27 commits into
skrub-data:mainfrom
jovan-stojanovic:fix_ken_output

Conversation

@jovan-stojanovic

Copy link
Copy Markdown
Member

Fix #599

@GaelVaroquaux GaelVaroquaux left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really think that slicing the strings is faster than the replace. Please correct me if I am wrong.

Comment thread skrub/datasets/_ken_embeddings.py Resolved
Comment thread skrub/datasets/_ken_embeddings.py Resolved
@jovan-stojanovic

Copy link
Copy Markdown
Member Author

Thanks, I think this is ready to be merged then. Not to confuse with #602 which maybe needs some additional work on :)

@GaelVaroquaux

Copy link
Copy Markdown
Member

Thanks. Maybe a small changelog entry, so as not to surprise users

@jovan-stojanovic

Copy link
Copy Markdown
Member Author

Actually now the main changes were made with #602, merging this just to update the changelog..

@jovan-stojanovic
jovan-stojanovic merged commit ddfa1a1 into skrub-data:main Jun 15, 2023
@jovan-stojanovic
jovan-stojanovic deleted the fix_ken_output branch July 21, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ken entity names should not have the preceding and trailing "<" and ">"

2 participants