Repository navigation
MAINT make pyarrow optional - #639
Merged
GaelVaroquaux merged 11 commits intoJul 18, 2023
Merged
Conversation
glemaitre
changed the title
GaelVaroquaux
requested changes
Jul 18, 2023
GaelVaroquaux
left a comment
GaelVaroquaux
left a comment
Member
There was a problem hiding this comment.
One minor change requested, plus:
- add in the docstring of all the functions skrub.datasets.fetch_ken* that they require the optional dependency pyarrow
- Add a note saying the same thing on top of https://skrub-data.org/stable/auto_examples/06_ken_embeddings_example.html
Member
Author
|
I added in the "Notes" section that |
Member
|
Can you add a changelog |
GaelVaroquaux
approved these changes
Jul 18, 2023
GaelVaroquaux
left a comment
GaelVaroquaux
left a comment
Member
There was a problem hiding this comment.
LGTM but needs changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
pyarrowoptional such that it can be imported withpyodide.