-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT make pyarrow optional #639
MAINT make pyarrow optional #639
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor change requested, plus:
- add in the docstring of all the functions skrub.datasets.fetch_ken* that they require the optional dependency pyarrow
- Add a note saying the same thing on top of https://skrub-data.org/stable/auto_examples/06_ken_embeddings_example.html
I added in the "Notes" section that |
Can you add a changelog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but needs changelog
Make
pyarrow
optional such that it can be imported withpyodide
.