FEAT Add aggregate and join functions for Pandas and Polars
#733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
Vincent-Maladiere
requested review from
LeoGrin,
GaelVaroquaux and
jovan-stojanovic
jovan-stojanovic
requested changes
Sep 6, 2023
| @@ -84,6 +84,46 @@ This page lists all available functions and classes of `skrub`. | |||
|
|
|||
| deduplicate | |||
|
|
|||
| .. raw:: html | |||
There was a problem hiding this comment.
Also, the API page is getting crowded. Maybe we can try to add subsections with a dropdown menu on the sidebar for .datasets and .dataframe methods (as a follow up PR maybe)
There was a problem hiding this comment.
Interesting suggestion, WDYT @GaelVaroquaux?
Co-authored-by: Jovan Stojanovic <62058944+jovan-stojanovic@users.noreply.github.com>
jovan-stojanovic
approved these changes
Sep 7, 2023
| @@ -0,0 +1,41 @@ | |||
| import pandas as pd | |||
There was a problem hiding this comment.
I think you need an __init__.py in this directory (at least with the current approach of having test modules be part of the package), otherwise for me locally pytest fails and complains it cannot import skrub.dataframe
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
This PR aims at simplifying #600 by adding the
dataframe._pandasanddataframe._polarsnamespaces prior to it.It also enables solving issues like #730.
This PR takes into account the latest reviews made in #600.
What does this PR implement?
skrub.dataframeso that thejoinandaggregatefunctions for Pandas and Polars can be shared more easily across skrub.get_df_namespacefunction and theDataFrameLike,SeriesLiketypes in separate files withinskrub.dataframe.Additional comments
This PR doesn't take into account the output of the discussion #719 for now.