Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] fix similarity encoder inverse transform #801

Merged
merged 4 commits into from
Nov 2, 2023
Merged

[MRG] fix similarity encoder inverse transform #801

merged 4 commits into from
Nov 2, 2023

Conversation

jeromedockes
Copy link
Contributor

closes #790

this is a quick fix + added test for the failure described in #790
the bigger problem of SimilarityEncoder subclassing the OneHotEncoder should still be addressed elsewhere

@jeromedockes jeromedockes changed the title fix similarity encoder inverse transform [MRG] fix similarity encoder inverse transform Oct 20, 2023
Vincent-Maladiere
Vincent-Maladiere approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@Vincent-Maladiere Vincent-Maladiere left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix the conflict and LGTM! It seems that we may be better off without subclassing the OHE indeed.

@Vincent-Maladiere Vincent-Maladiere mentioned this pull request Oct 31, 2023
Open
@Vincent-Maladiere Vincent-Maladiere merged commit fb04fd0 into skrub-data:main Nov 2, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vincent-Maladiere Vincent-Maladiere Vincent-Maladiere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AttributeError in SimilarityEncoder inverse_transform
2 participants
@jeromedockes @Vincent-Maladiere