Rename TableVectorizer parameters

[jeromedockes]

rename the TableVectorizer parameters and corresponding attributes according to #671 and this morning's skrub meeting discussion:

cardinality_threshold → n_unique_threshold
high_cardinality_transformer → many_unique
low_cardinality_transformer → few_unique
datetime_transformer → datetime
numeric_transformer → numeric

I'm not 100% sure the new names are better esp. the "cardinality" replacement 🤔

[TheooJ]

I like the removal of transformer everywhere but I'm not sold on many_unique and few_unique yet

[GaelVaroquaux]

I started a twitter poll on this: https://x.com/skrub_data/status/1803508324941402198

[jeromedockes]

it's a detail but I put many_unique without an S instead of many_uniques because the polars and pandas functions are called n_unique (no s) and I don't think 'unique' as a noun exists in english

[GaelVaroquaux]

it's a detail but I put many_unique without an S instead of many_uniques because the polars and pandas functions are called n_unique (no s)

Good thinking

[GaelVaroquaux]

Result of the twitter poll

[TheooJ]

I prefer this option too

[jeromedockes]

ok then I'll update the PR to just drop the transformer part and keep 'cardinality'

[TheooJ]

Thanks @jeromedockes !