Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT xfail the fetch_movielens test #971

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

jeromedockes
Copy link
Member

this test if causing the CI to fail due to a download error. here also, (as for the ken embeddings) the real fix is to mock doownloads in tests but in the meanwhile this allows the ci to run @glemaitre

@jeromedockes
Copy link
Member Author

also fix the unbound local variable error

@jeromedockes jeromedockes merged commit 81e5e5b into skrub-data:main Jun 24, 2024
20 of 22 checks passed
@jeromedockes jeromedockes deleted the xfail-movielens-test branch June 25, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants