Add compound word token filter types into analysis package #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is one unrelated test failing because of the issue described here |
nelusnegur
changed the title
added 2 commits
September 13, 2019 08:42
Merge upstream/master into fork/master
|
The unrelated failing test was fixed, and I rebased onto master; so this PR is now ready to be reviewed. @sksamuel when you have time, please take a look 🙂 |
|
Good work thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's not possible to create an instance of
analysis.CompoundWordTokenFilterbecause there are no defined values for theanalysis.CompoundWordTokenFilterType.This PR aims to fix this issue by defining the types of a compounded word token filter supported by Elasticsearch, in the new
analysispackage.