Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #220 skip unix permission check on windows when loading webp binaries #221

Merged
merged 1 commit into from
Feb 1, 2021
Merged

FIX #220 skip unix permission check on windows when loading webp binaries #221

merged 1 commit into from
Feb 1, 2021

Conversation

SightStudio
Copy link
Contributor

@SightStudio SightStudio commented Feb 1, 2021

skip chmod command on windows when load cwebp, dwebp binaries.

WebpHandler in scrimage-webp

private static boolean setExecutable(Path output) throws IOException {
    try {
        return new ProcessBuilder("chmod", "+x", output.toAbsolutePath().toString())
            .start()
            .waitFor(30, TimeUnit.SECONDS);
    } catch (InterruptedException e) {
        throw new IOException(e);
    }
}

@SightStudio SightStudio changed the title FIX #220 skip unix permission check on windows FIX #220 skip unix permission check on windows when load webp binaries Feb 1, 2021
@SightStudio SightStudio changed the title FIX #220 skip unix permission check on windows when load webp binaries FIX #220 skip unix permission check on windows when loading webp binaries Feb 1, 2021
@sksamuel sksamuel merged commit cbe15c8 into sksamuel:master Feb 1, 2021
@sksamuel
Copy link
Owner

sksamuel commented Feb 1, 2021

Nice, thanks. Will release a version with this fix.

@SightStudio SightStudio deleted the feature/webp_window_support branch February 1, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants