Skip to content

Commit

Permalink
[MNT] simplify wheels test for release (#123)
Browse files Browse the repository at this point in the history
This PR simplifies the test of wheels for release, and removes the
dependency on miniconda which seems to have issues with python 3.12.
  • Loading branch information
fkiraly committed Oct 10, 2023
1 parent 55cf0f3 commit 587be54
Showing 1 changed file with 4 additions and 77 deletions.
81 changes: 4 additions & 77 deletions .github/workflows/wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,14 @@ jobs:
name: wheels
path: wheelhouse/*

test_unix_wheels:
test_wheels:
needs: build_wheels
name: Test wheels on ${{ matrix.os }} with ${{ matrix.python-version }}
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-20.04, macOS-11]
python-version: ['3.8', '3.9', '3.10', '3.11', '3.11']
os: [ubuntu-latest, macOS-latest, windows-latest]
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']

steps:
- uses: actions/checkout@v4
Expand All @@ -57,83 +57,10 @@ jobs:
run: |
python -m pytest
test_windows_wheels:
needs: build_wheels
name: Test wheels on ${{ matrix.os }} with ${{ matrix.python-version }}
runs-on: windows-2019
strategy:
matrix:
include:
# Window 64 bit
- os: windows-2019
python: 38
python-version: '3.8'
bitness: 64
platform_id: win_amd64
- os: windows-2019
python: 39
python-version: '3.9'
bitness: 64
platform_id: win_amd64
- os: windows-2019
python: 310
python-version: '3.10'
bitness: 64
platform_id: win_amd64
- os: windows-2019
python: 311
python-version: 3.11
bitness: 64
platform_id: win_amd64
- os: windows-2019
python: 312
python-version: 3.12
bitness: 64
platform_id: win_amd64

steps:
- uses: actions/checkout@v4
- uses: conda-incubator/setup-miniconda@v2
with:
activate-environment: test
auto-update-conda: true
python-version: ${{ matrix.python-version }}
channels: anaconda, conda-forge,

- run: conda --version
- run: which python

- uses: actions/download-artifact@v3
with:
name: wheels
path: wheelhouse

- name: Install conda libpython
run: conda install -c anaconda -n test -y libpython

- name: Display downloaded artifacts
run: ls -l wheelhouse

- name: Get wheel filename
run: echo "WHEELNAME=$(ls ./wheelhouse/skpro-*none-any.whl)" >> $env:GITHUB_ENV

- name: Activate conda env
run: conda activate test

- name: Install wheel and extras
run: python -m pip install "${env:WHEELNAME}[all_extras,dev]"

- name: Show conda packages
run: conda list -n test

- name: Run tests
run: |
python -m pytest
upload_wheels:
name: Upload wheels to PyPI
runs-on: ubuntu-latest
needs: [build_wheels,test_unix_wheels,test_windows_wheels]
needs: [build_wheels,test_wheels]

steps:
- uses: actions/download-artifact@v3
Expand Down

0 comments on commit 587be54

Please sign in to comment.