Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] move BaseDistribution.sample method to boilerplate layered design #346

Open
fkiraly opened this issue May 19, 2024 · 0 comments
Open

[ENH] move BaseDistribution.sample method to boilerplate layered design #346

fkiraly opened this issue May 19, 2024 · 0 comments
Labels
enhancement good first issue Good for newcomers

Comments

@fkiraly
Copy link
Collaborator

fkiraly commented May 19, 2024

The sample method of BaseDistribution currently has a single default implementation and needs to be entirely overridden for extension.

This should be moved to the boilerplate layer design, sample / _sample.

Todos:

  • add the two layers in BaseDistribution
  • move any current overrides into the private layer, search for def sample. Duplicated boilerplate can be removed.
  • document the new extension contract in extension_templates/distributions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fkiraly