Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] ensure pytest options are set in make test #127

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Oct 10, 2023

make test does not seem to respect the pytest options - hypothesis, this is due to a lacking pytest options reference in the makefile.

@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Oct 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (98547bb) 70.00% compared to head (ccb3f2f) 69.95%.
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   70.00%   69.95%   -0.05%     
==========================================
  Files          97       97              
  Lines        5157     5156       -1     
  Branches      952      952              
==========================================
- Hits         3610     3607       -3     
- Misses       1317     1319       +2     
  Partials      230      230              

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fkiraly
Copy link
Collaborator Author

fkiraly commented Oct 10, 2023

hm, doesnt seem to have worked...

@fkiraly fkiraly marked this pull request as draft October 10, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants