Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Log-normal probability distribution #218

Merged
merged 14 commits into from Apr 18, 2024
Merged

Conversation

bhavikar04
Copy link
Contributor

@bhavikar04 bhavikar04 commented Mar 24, 2024

Reference Issues/PRs

#22

What does this implement/fix? Explain your changes.

Lognormal probability distribution

Does your contribution introduce a new dependency? If yes, which one?

no

What should a reviewer concentrate their feedback on?

Did you add any tests for the change?

no

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors with any new badges I've earned :-)
    How to: add yourself to the all-contributors file in the skpro root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release.
    See here for full badge reference
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
For new estimators
  • I've added the estimator to the API reference - in docs/source/api_reference/taskname.rst, follow the pattern.
  • I've added one or more illustrative usage examples to the docstring, in a pydocstyle compliant Examples section.
  • If the estimator relies on a soft dependency, I've set the python_dependencies tag and ensured
    dependency isolation, see the estimator dependencies guide.

@bhavikar04 bhavikar04 changed the title Lognormal probability distribution [ENH] Lognormal probability distribution Mar 24, 2024
@fkiraly fkiraly mentioned this pull request Mar 24, 2024
4 tasks
@fkiraly fkiraly added enhancement module:probability&simulation probability distributions and simulators labels Apr 7, 2024
@fkiraly
Copy link
Collaborator

fkiraly commented Apr 7, 2024

do you need feedback on this?
I left some comments on the old version: #214

FYI, you do not need to close PR to update them, if you update the branch on your fork, the PR will automatically update.

@bhavikar04
Copy link
Contributor Author

do you need feedback on this? I left some comments on the old version: #214

FYI, you do not need to close PR to update them, if you update the branch on your fork, the PR will automatically update.

the energy functional hasn't been worked out

@bhavikar04 bhavikar04 marked this pull request as ready for review April 10, 2024 09:53
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Looks ok. Can you quickly explain how you arrived at the energy term?

Also, please make sure to format your code properly, or the tests will not run:
https://www.sktime.net/en/stable/developer_guide/coding_standards.html

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you did not comment, I assume you are no longer working on this, so I've wrapped this up now for merge

@fkiraly fkiraly merged commit 0f0248c into sktime:main Apr 18, 2024
36 checks passed
@fkiraly fkiraly changed the title [ENH] Lognormal probability distribution [ENH] Log-normal probability distribution Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement module:probability&simulation probability distributions and simulators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants