[ENH] simplified interface to Johnson QPD #254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
module:probability&simulation
fkiraly
added a commit
that referenced
this pull request
Apr 19, 2024
This PR adds a delegator class for distributions, delegating all public methods. Similar to delegators for other object types, tag and params are not delegated. The class is tested via #254 - the delegation works, the failures are genuine and identical with when tests are being turned on for the QPD distributions.
5 tasks
5 tasks
|
supserseded by #232 which contains this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simplified interface to the three Johnson QPD (bounded, lower semi-bounded, unbounded) to the module.
The interface uses the delegator introduced in #252, and is a simple parameter based dispatcher:
lowerandupper, and the other parameters which are common toQPD_U,QPD_S,QPD_Blowerandupperare not provided, it dispatches toQPD_Uloweris provided but notupper, it dispatches toQPD_SQPD_BAs previously discussed in #232 - moving to an umbrella interface might also make the work carried out there easier.
What do you think, @setoguchi-naoki, @FelixWick?