Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Student's t-distribution #49

Merged
merged 4 commits into from Aug 27, 2023
Merged

Conversation

Alex-JG3
Copy link
Contributor

@Alex-JG3 Alex-JG3 commented Aug 27, 2023

Reference Issues/PRs

Mirror of sktime sktime/sktime#5050. Towards #22

What does this implement/fix? Explain your changes.

Add student's t-distribution.

Does your contribution introduce a new dependency? If yes, which one?

No

What should a reviewer concentrate their feedback on?

Any other comments?

PR checklist

For all contributions
  • I've reviewed the project documentation on contributing
  • I've added myself to the list of contributors.
  • The PR title starts with either [ENH], [CI/CD], [MNT], [DOC], or [BUG] indicating whether
    the PR topic is related to enhancement, CI/CD, maintenance, documentation, or a bug.
For code contributions
  • Unit tests have been added covering code functionality
  • Appropriate docstrings have been added (see documentation standards)
  • New public functionality has been added to the API Reference

@fkiraly fkiraly changed the title [ENH]Add student's t-distribution [ENH] Student's t-distribution Aug 27, 2023
@fkiraly fkiraly added enhancement module:probability&simulation probability distributions and simulators implementing algorithms Implementing algorithms, estimators, objects native to skpro labels Aug 27, 2023
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I fixed some minor things:

  • docstring example import
  • first line, currently older precommit version than sktime

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2023

Codecov Report

Merging #49 (6bb62c4) into main (7fa2aa6) will increase coverage by 0.47%.
The diff coverage is 98.75%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   70.56%   71.03%   +0.47%     
==========================================
  Files         102      103       +1     
  Lines        4709     4789      +80     
  Branches      847      853       +6     
==========================================
+ Hits         3323     3402      +79     
  Misses       1166     1166              
- Partials      220      221       +1     
Files Changed Coverage Δ
skpro/distributions/t.py 98.75% <98.75%> (ø)

@fkiraly fkiraly merged commit 3947650 into sktime:main Aug 27, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement implementing algorithms Implementing algorithms, estimators, objects native to skpro module:probability&simulation probability distributions and simulators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants