Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Refactor of BaseDistribution and descendants - generalised distribution param broadcasting in base class #54

Merged
merged 1 commit into from Aug 31, 2023

Conversation

Alex-JG3
Copy link
Contributor

Reference Issues/PRs

Copied from this PR from sktime sktime/sktime#5176

What does this implement/fix? Explain your changes.

Refactors the _get_bc_params function in the BaseDistribution class.

Does your contribution introduce a new dependency? If yes, which one?

No.

What should a reviewer concentrate their feedback on?

Any other comments?

PR checklist

For all contributions
  • I've reviewed the project documentation on contributing
  • I've added myself to the list of contributors.
  • The PR title starts with either [ENH], [CI/CD], [MNT], [DOC], or [BUG] indicating whether
    the PR topic is related to enhancement, CI/CD, maintenance, documentation, or a bug.
For code contributions
  • Unit tests have been added covering code functionality
  • Appropriate docstrings have been added (see documentation standards)
  • New public functionality has been added to the API Reference

@codecov-commenter
Copy link

Codecov Report

Merging #54 (ac061b9) into main (d1b693f) will decrease coverage by 0.21%.
The diff coverage is 55.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
- Coverage   71.19%   70.98%   -0.21%     
==========================================
  Files         107      107              
  Lines        4958     4950       -8     
  Branches      887      886       -1     
==========================================
- Hits         3530     3514      -16     
- Misses       1195     1201       +6     
- Partials      233      235       +2     
Files Changed Coverage Δ
...o/distributions/tests/test_base_default_methods.py 37.93% <0.00%> (ø)
skpro/distributions/base.py 63.27% <50.00%> (-0.82%) ⬇️
skpro/distributions/laplace.py 100.00% <100.00%> (ø)
skpro/distributions/normal.py 100.00% <100.00%> (ø)
skpro/distributions/t.py 98.61% <100.00%> (-0.14%) ⬇️

@fkiraly fkiraly added enhancement module:probability&simulation probability distributions and simulators implementing framework Implementing or improving framework for learning tasks, e.g., base class functionality labels Aug 29, 2023
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fkiraly fkiraly merged commit 1ce6f30 into sktime:main Aug 31, 2023
27 checks passed
@fkiraly fkiraly changed the title [ENH] Refactor of BaseDistribution and descendants - generalised distribution param broadcasting in base class [ENH] Refactor of BaseDistribution and descendants - generalised distribution param broadcasting in base class Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement implementing framework Implementing or improving framework for learning tasks, e.g., base class functionality module:probability&simulation probability distributions and simulators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants