Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change assumed shape of time series to timepoints*channels #11

Merged
merged 2 commits into from
Aug 3, 2021

Conversation

SveaMeyer13
Copy link
Collaborator

I assumed the shape of sktime time series to be channels * timepoints (as it is for example defined in mne). But when reviewing the specifications made in PR #1232 in sktime, I figured that it is supposed to be timepoints * channels.

This required changes in

  • the two series-to-series transformers
  • the epoching function and
  • the example notebook.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@fkiraly
Copy link

fkiraly commented Aug 2, 2021

@SveaMeyer13, on this note: in the sktime branch datatypes-doc I've added an example notebook 00-datatypes which spells out the machine type specifications of series and panel data. Optimally, any in-memory container convention should comply with one of the conventions specified in there.

Now I'm aware this is the first time we've actually written this down, so any input is appreciated. Especially if you think we need a different in-memory representation of an existing scitype, or new scitypes even, to support your designs for sktime-neuro.

@TonyBagnall TonyBagnall merged commit 934d43f into main Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants