Skip to content

Commit

Permalink
Code review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
kianmeng committed Oct 15, 2023
1 parent cff1c30 commit 45cbe32
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion docs/source/api_reference/dists_kernels.rst
Expand Up @@ -181,7 +181,7 @@ See docstring of ``AggrDist`` and ``FlatDist``.
AggrDist
FlatDist

Advanced time series kernels that cannot be expressed as aggrgates or flat applicants:
Advanced time series kernels that cannot be expressed as aggregates or flat aggregates:

.. currentmodule:: sktime.dists_kernels.gak

Expand Down
2 changes: 1 addition & 1 deletion sktime/base/_meta.py
Expand Up @@ -783,7 +783,7 @@ def is_flat(obj):


class _ColumnEstimator:
"""Mixin class with utilities for by-column applicants."""
"""Mixin class with utilities for by-column aggregates."""

def _coerce_to_pd_index(self, obj, ref=None):
"""Coerce obj to pandas Index, replacing ints by index elements.
Expand Down
4 changes: 3 additions & 1 deletion sktime/benchmarking/benchmarks.py
Expand Up @@ -10,7 +10,9 @@
from sktime.utils.validation._dependencies import _check_soft_dependencies


def is_initialised_estimator(estimator: BaseEstimator) -> bool:
# TODO: typo but need to be deprecated
# See https://www.sktime.net/en/stable/developer_guide/deprecation.html
def is_initalised_estimator(estimator: BaseEstimator) -> bool:
"""Check if estimator is initialised BaseEstimator object."""
if isinstance(estimator, BaseEstimator):
return True
Expand Down

0 comments on commit 45cbe32

Please sign in to comment.