Skip to content

Commit

Permalink
disable probabilistic capability of StatsForecastMSTL
Browse files Browse the repository at this point in the history
  • Loading branch information
yarnabrina committed Feb 14, 2024
1 parent 3642215 commit 9ebe468
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 2 deletions.
12 changes: 10 additions & 2 deletions sktime/forecasting/statsforecast.py
Expand Up @@ -796,8 +796,8 @@ class StatsForecastMSTL(_GeneralisedStatsForecastAdapter):
# estimator type
# --------------
"ignores-exogeneous-X": True,
"capability:pred_int": True,
"capability:pred_int:insample": True,
"capability:pred_int": False,
"capability:pred_int:insample": False,
"python_dependencies": ["statsforecast>=1.2.0"],
}

Expand All @@ -815,6 +815,14 @@ def __init__(

super().__init__()

# adapter class sets probabilistic capability as true
# because level is present in statsforecast signature
# happens in _check_supports_pred_int method
# manually overriding this temporarily
self.set_tags(
**{"capability:pred_int": False, "capability:pred_int:insample": False}
)

from sklearn.base import clone

if trend_forecaster:
Expand Down
3 changes: 3 additions & 0 deletions sktime/forecasting/tests/test_statsforecast.py
Expand Up @@ -14,6 +14,9 @@
from sktime.tests.test_switch import run_test_for_class


@pytest.mark.skip(
reason="probabilistic capability of StatsForecastMSTL is disabled, see #5703, #5920"
)
@pytest.mark.skipif(
not run_test_for_class(StatsForecastMSTL),
reason="run test only if softdeps are present and incrementally (if requested)",
Expand Down
2 changes: 2 additions & 0 deletions sktime/tests/_config.py
Expand Up @@ -189,6 +189,8 @@
"LTSFDLinearForecaster": ["test_predict_time_index_in_sample_full"],
"LTSFNLinearForecaster": ["test_predict_time_index_in_sample_full"],
"WEASEL": ["test_multiprocessing_idempotent"], # see 5658
# StatsForecastMSTL is failing in probabistic forecasts, see #5703, #5920
"StatsForecastMSTL": ["test_pred_int_tag", "test_statsforecast_mstl"],
}

# We use estimator tags in addition to class hierarchies to further distinguish
Expand Down

0 comments on commit 9ebe468

Please sign in to comment.