Skip to content

Commit

Permalink
[ENH] remove private methods from parameters of ProximityForest, `P…
Browse files Browse the repository at this point in the history
…roximityTree`, and `ProximityStump` (#6046)

<!--
Welcome to sktime, and thanks for contributing!
Please have a look at our contribution guide:
https://www.sktime.net/en/latest/get_involved/contributing.html
-->

#### Reference Issues/PRs
<!--
Example: Fixes #1234. See also #3456.

Please use keywords (e.g., Fixes) to create link to the issues or pull
requests
you resolved, so that they will automatically be closed when your pull
request
is merged. See
https://github.com/blog/1506-closing-issues-via-pull-requests.
If no issue exists, you can open one here:
https://github.com/sktime/sktime/issues
-->
Fixes #5042

#### What does this implement/fix? Explain your changes.
<!--
A clear and concise description of what you have implemented.
-->
Removed methods that were being instantiated with the objects of
`ProximityForest`, `ProximityTree`, and `ProximityStump` classes and
made them the class methods.

For the `get_gain` method which defaults to `gini_gain` I added a
dictionary to track the gain functions in case there is more gain
functions added in the future.

Methods changed

- [x] `setup_distance_measure`
- [x]  `get_exemplars`
- [x]  `get_distance_measure`
- [x]  `find_stump`
- [x]  `get_gain`
  • Loading branch information
fnhirwa committed Mar 15, 2024
1 parent c5af6ea commit e362733
Show file tree
Hide file tree
Showing 2 changed files with 364 additions and 293 deletions.
10 changes: 10 additions & 0 deletions .all-contributorsrc
Expand Up @@ -2644,6 +2644,16 @@
"contributions": [
"maintenance"
]
},
{
"login": "fnhirwa",
"name": "Felix Hirwa Nshuti",
"avatar_url": "https://avatars.githubusercontent.com/u/67042527?s=64&v=4",
"profile": "https://github.com/fnhirwa",
"contributions": [
"code",
"maintenance"
]
}
]
}

0 comments on commit e362733

Please sign in to comment.