Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ENH] remove private methods from parameters of
ProximityForest
, `P…
…roximityTree`, and `ProximityStump` (#6046) <!-- Welcome to sktime, and thanks for contributing! Please have a look at our contribution guide: https://www.sktime.net/en/latest/get_involved/contributing.html --> #### Reference Issues/PRs <!-- Example: Fixes #1234. See also #3456. Please use keywords (e.g., Fixes) to create link to the issues or pull requests you resolved, so that they will automatically be closed when your pull request is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests. If no issue exists, you can open one here: https://github.com/sktime/sktime/issues --> Fixes #5042 #### What does this implement/fix? Explain your changes. <!-- A clear and concise description of what you have implemented. --> Removed methods that were being instantiated with the objects of `ProximityForest`, `ProximityTree`, and `ProximityStump` classes and made them the class methods. For the `get_gain` method which defaults to `gini_gain` I added a dictionary to track the gain functions in case there is more gain functions added in the future. Methods changed - [x] `setup_distance_measure` - [x] `get_exemplars` - [x] `get_distance_measure` - [x] `find_stump` - [x] `get_gain`
- Loading branch information