New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] ensure Prophet
can deal with PeriodIndex
#2475
Comments
back in the days we have decided to accept only pandas-dev/pandas#38914 So we might have to implement a custom dummy index conversion: |
But already our example datasets violate this input assumption, e.g., |
yes, we should actually open an issue at |
with last release over a year ago? Can try, but sounds unlikely... |
… not working with non-integer forecast horizon (#3995) This PR adds functionality to the `Prophet` interface to also allow `pd.PeriodIndex`. Fixes #2475 and also fixes #3537. Also tests: * testing `Prophet` functionality for `RangeIndex` and `PeriodIndex` in exogeneous and endogeneous data * testing failure case in #3537
This removes the exception from testing `Prophet` with `pd.DatetimeIndex` or `pd.PeriodIndex`. Recent changes in `Prophet` and framework to fix the issue #2475 also fix the failures in the excepted test.
Currently,
Prophet
errors out when given data frames withPeriodIndex
, due to the interfaced facebook prophet not liking that index (and catch statements in our interface).We may want to add some intermediate functionality to enable
Prophet
to also deal withPeriodIndex
? In that case, I'd simply convert it to the first time stamp in a period, then applyProphet
as is, and at the end convert back toPeriodIndex
.Good first issue, the one non-obvious thing perhaps is that the places to look at includes the
_ProphetAdapter
class as well.The text was updated successfully, but these errors were encountered: