Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] contributors.md not updating? #2905

Closed
fkiraly opened this issue Jul 1, 2022 · 7 comments · Fixed by #3807
Closed

[BUG] contributors.md not updating? #2905

fkiraly opened this issue Jul 1, 2022 · 7 comments · Fixed by #3807
Labels
bug Something isn't working documentation Documentation & tutorials good first issue Good for newcomers maintenance Continuous integration, unit testing & package distribution

Comments

@fkiraly
Copy link
Collaborator

fkiraly commented Jul 1, 2022

Update: there's a "hard" and an "easy" (good first issue) problem here.

easy = running the cmdline tool locally and making a PR with the generated contributors.md

hard = automating this in the CI (e.g., release script)

(and we close it only once we have automation done)


It seems the contributors.md has not updated since 0.9.0 - are we doing sth wrong with the release?

Did we accidentally drop sth from the release script when we moved to GHA that re-generated the contributors.md?

FYI @lmmentel, @freddyaboulton

@fkiraly fkiraly added bug Something isn't working documentation Documentation & tutorials labels Jul 1, 2022
@lmmentel
Copy link
Contributor

lmmentel commented Jul 2, 2022

Good catch, do you know how were they updated in the past? I've checked the history and those updates are a part of release PR but it's hard to say if this was a manual or automated edit.

@lmmentel lmmentel added the maintenance Continuous integration, unit testing & package distribution label Jul 2, 2022
@fkiraly
Copy link
Collaborator Author

fkiraly commented Jul 2, 2022

Good catch, do you know how were they updated in the past? I've checked the history and those updates are a part of release PR but it's hard to say if this was a manual or automated edit.

I suspect, one of these:
https://allcontributors.org/docs/en/tooling

@mloning might know more.

@mloning
Copy link
Contributor

mloning commented Jul 11, 2022

Think it's still manual. I tried installing the bot a few times but couldn't get it to work.

@fkiraly
Copy link
Collaborator Author

fkiraly commented Jul 23, 2022

Docs are still here:
https://allcontributors.org/docs/en/cli/installation

Think it's still manual.

Do you mean manual, as there is something you can locally and commit - or, manual as in having to translate the all-contributors line by line??

@mloning
Copy link
Contributor

mloning commented Jul 30, 2022

Do you mean manual, as there is something you can locally and commit - or, manual as in having to translate the all-contributors line by line??

Using their command line client (the link you posted)

@fkiraly fkiraly added the good first issue Good for newcomers label Aug 1, 2022
@fkiraly
Copy link
Collaborator Author

fkiraly commented Aug 1, 2022

hm, looks straighforward enough - so someone should be able to do that locally and simply make a PR with the updated file, until we figure out how to automate it.

@achieveordie
Copy link
Collaborator

I think the most direct solution will be to have a GitHub bot perform this operation whenever it notices a change in .all_contributorsrc. There's already a bot that they provide but even that requires a cue to perform a PR so we might as well create one for added flexibility.

fkiraly pushed a commit that referenced this issue Nov 17, 2022
See #2905 for reference.

Locally ran `all-contributors-cli` via npm to update `CONTRIBUTORS.md` to include new changes. The last update was two months ago so I thought it'll be great to have it updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Documentation & tutorials good first issue Good for newcomers maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants