New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] contributors.md not updating? #2905
Comments
Good catch, do you know how were they updated in the past? I've checked the history and those updates are a part of release PR but it's hard to say if this was a manual or automated edit. |
I suspect, one of these: @mloning might know more. |
Think it's still manual. I tried installing the bot a few times but couldn't get it to work. |
Docs are still here:
Do you mean manual, as there is something you can locally and commit - or, manual as in having to translate the all-contributors line by line?? |
Using their command line client (the link you posted) |
hm, looks straighforward enough - so someone should be able to do that locally and simply make a PR with the updated file, until we figure out how to automate it. |
I think the most direct solution will be to have a GitHub bot perform this operation whenever it notices a change in |
See #2905 for reference. Locally ran `all-contributors-cli` via npm to update `CONTRIBUTORS.md` to include new changes. The last update was two months ago so I thought it'll be great to have it updated.
Update: there's a "hard" and an "easy" (good first issue) problem here.
easy = running the cmdline tool locally and making a PR with the generated contributors.md
hard = automating this in the CI (e.g., release script)
(and we close it only once we have automation done)
It seems the contributors.md has not updated since 0.9.0 - are we doing sth wrong with the release?
Did we accidentally drop sth from the release script when we moved to GHA that re-generated the contributors.md?
FYI @lmmentel, @freddyaboulton
The text was updated successfully, but these errors were encountered: