Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH][MNT] testing version bumps, e.g., dependabot upgrades - how to ensure objets affected by soft dependency changes are tested #5292

Open
fkiraly opened this issue Sep 23, 2023 · 4 comments
Labels
enhancement Adding new functionality maintenance Continuous integration, unit testing & package distribution module:tests test framework functionality - only framework, excl specific tests

Comments

@fkiraly
Copy link
Collaborator

fkiraly commented Sep 23, 2023

question: how do we test, between releases, compatibility of an estimator with a soft dependency if we/dependabot bump the upper bound of said dependency?

problem:

  • we do diff testing, test estimators only if their module has changed
  • so when bumping the soft dep only, the estimator will not change

Currently, I have been manually merging to main and then running the "run all estimators" diagnostic #5083, but that is highly manual.

Some solutions that we have discussed on the discord:

There is not just the tech side, but also the "release manager instructions" side, and the "developer instructions" side - we do not want to ovecomplicate the instructions, or introduce too many things that one has to think of at the right time, or we introduce risk through less streamlined process.

FYI @yarnabrina, @romanlutz, @benHeid. Also @tarpas as possibly interested.

@fkiraly fkiraly added maintenance Continuous integration, unit testing & package distribution module:tests test framework functionality - only framework, excl specific tests enhancement Adding new functionality labels Sep 23, 2023
@fkiraly fkiraly changed the title [ENH][MNT] testing version bumps, e.g., dependabot upgrades [ENH][MNT] testing version bumps, e.g., dependabot upgrades - how to ensure objets affected by soft dependency changes are tested Sep 23, 2023
@fkiraly
Copy link
Collaborator Author

fkiraly commented Sep 23, 2023

Here's an idea: in GHA, can we check whether a PR comes from dependabot, and in this case turn off the "differential testing" flag? That would be only_changed_modules.

@yarnabrina
Copy link
Collaborator

I am not sure if "PR created by dependabot" can be detected directly or not, but PR title/label/etc. can be detected. And we are already controlling the labels, so that can be the easy way forward. We can create special tags for manual/automated dependency updates.

- "maintenance"

@fkiraly
Copy link
Collaborator Author

fkiraly commented Sep 23, 2023

We can create special tags for manual/automated dependency updates.

Sounds good! And these would trigger full CI?

@yarnabrina
Copy link
Collaborator

I don't think so, at least not automatically. I was just answering the "can" question, assuming you know how to do the "turn off" part.

I suppose once we detect the label, there seems to be existing actions for that, we can set some environment variables or pass specific CLI flags (never tried myself, but don't see why it can't be done). Will that be enough to control pytest_generate_tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding new functionality maintenance Continuous integration, unit testing & package distribution module:tests test framework functionality - only framework, excl specific tests
Projects
None yet
Development

No branches or pull requests

2 participants