-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNT] refactoring new CI to fix some bugs and other minor enhancements #5638
Conversation
51754fa
to
6a512ea
Compare
6f53b13
to
570b329
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am confused with the PR title - it says it fixes typos, but there are entire files added in workflows
- is this a mistake, or are file renames and changes happening in the same PR?
The typo fix is the main change what was causing the issue that few tests were not running in new CI. However, fixing that led to copilot and github docs suggesting some other changes to simplify maintenance, so added those as well. I renamed the PR now, but not sure if it's suitable. All the details are part of the description. |
570b329
to
2511c51
Compare
2511c51
to
8190403
Compare
1. fix main typo: sktime-component was using detect_components_with_extras which is undefined 2. split test_components into two separate workflows: 1. one to test individual components using dedicated extras and reuse defined actions 2. one to test all other components without extras using all_extras_pandas2 3. split long commands into multiple lines using YAML multiline strings (ref. https://yaml-multiline.info/) 4. skip duplicated testing of base as part of testing components without dedicated extras 5. remove coverage in partial tests 6. add coverage in full tests if missing 7. added validation of all_extras_pandas2 8. minor changes (mostly renaming) in some places
8190403
to
f0ce0c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notes/Summary #5559 - addressed by this PR. #5671 - partially addressed as |
Fixes #5559 (indirectly depends on #5670 for all tests to pass as part of #5639)
This fixes few bugs (typos, possibly unreliable coverage, etc.) and added some minor enhancements in new CI.
The changes are tested in #5639 and as it can be seen in https://github.com/sktime/sktime/actions/runs/7339442367, both components with and without extras trigger sub-jobs as expected.