Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] in evaluate, kwargs for backend configuration do nothing #5310

Closed
fkiraly opened this issue Sep 24, 2023 · 0 comments · Fixed by #5311
Closed

[BUG] in evaluate, kwargs for backend configuration do nothing #5310

fkiraly opened this issue Sep 24, 2023 · 0 comments · Fixed by #5311
Labels
bug Something isn't working module:forecasting forecasting module: forecasting, incl probabilistic and hierarchical forecasting module:metrics&benchmarking metrics and benchmarking modules

Comments

@fkiraly
Copy link
Collaborator

fkiraly commented Sep 24, 2023 •
edited

In the benchmarking utility forecasting.model_evaluation.evaluate, the kwargs, claimed in the docstring to be useable for backend configuration, do nothing.

This should be repaired or replaced.
@fkiraly fkiraly added bug Something isn't working module:forecasting forecasting module: forecasting, incl probabilistic and hierarchical forecasting module:metrics&benchmarking metrics and benchmarking modules labels Sep 24, 2023
@fkiraly fkiraly mentioned this issue Sep 24, 2023
Merged
fkiraly added a commit that referenced this issue Oct 7, 2023
@fkiraly
[ENH] parallelization backend calls in utility module - part 2, backe…
1d37baf 
…nd parameter passing (#5311)

This PR builds on the refactoring of parallelization of backend calls in
#5268.

It introduces a parameter `backend_params`, by which parameters can be
passed on to the parallelization backend, along lines of suggestions by
@hazrulakmal in
#5268 (comment) (I
went with `dict` as that allows simple `**params` calls, and this is
closest to current syntax in pre-refactor cases).

This parameter is tied in to the refactor targets in
#5268, i.e.,
`VectorizedDF.vectorized_est` and `model_evaluation.evaluate`, so
`backend_params` can now be passed to both:

In addition:

* fixes #5310 by removing the
unused `kwargs` `evaluate` and replacing the intended functionality with
an actually functioning `backend_params` argument. Adds a deprecation
warning to ensure we do not break code downstream where params are
passed (even if they are not used)
* makes various docstring improvements and adds explanation of possible
backend values.

Depends on:

* the refactored parallelization backend in
#5268
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working module:forecasting forecasting module: forecasting, incl probabilistic and hierarchical forecasting module:metrics&benchmarking metrics and benchmarking modules
Projects
None yet
Milestone
No milestone
1 participant
@fkiraly