Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] new CI not covered by cancel workflow #5525

Closed
fkiraly opened this issue Nov 3, 2023 · 4 comments
Closed

[ENH] new CI not covered by cancel workflow #5525

fkiraly opened this issue Nov 3, 2023 · 4 comments
Labels
bug Something isn't working maintenance Continuous integration, unit testing & package distribution

Comments

@fkiraly
Copy link
Collaborator

fkiraly commented Nov 3, 2023

Previously, updates to a PR would cancel jobs arising from previous versions immediately before starting new jobs.

This does not seem to extend to the new CI, which can lead to a large amount of jobs being triggered

FYI @yarnabrina.

@fkiraly fkiraly added bug Something isn't working maintenance Continuous integration, unit testing & package distribution labels Nov 3, 2023
@yarnabrina
Copy link
Collaborator

I am aware and it is intentional from my part. Old CI uses it only for install and test workflow and not for others as well, and the action itself recommends not using it and switch to newer GHA keywords.

My plan was to explore this after old vs new and etc. CI discussions are over.

@fkiraly
Copy link
Collaborator Author

fkiraly commented Nov 3, 2023

My plan was to explore this after old vs new and etc. CI discussions are over.

Ok - don't think it's a "vs" discussion imo. My priority in this is not reducing case coverage.

@yarnabrina
Copy link
Collaborator

@fkiraly can we close this? It's covered by #6074 I think.

@fkiraly
Copy link
Collaborator Author

fkiraly commented Apr 14, 2024

yes, agree

@fkiraly fkiraly closed this as completed Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

No branches or pull requests

2 participants