Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] should CI for a pyproject.toml change turn off incremental testing? #5544

Open
fkiraly opened this issue Nov 8, 2023 · 2 comments
Open
Labels
enhancement Adding new functionality module:tests test framework functionality - only framework, excl specific tests

Comments

@fkiraly
Copy link
Collaborator

fkiraly commented Nov 8, 2023

Question for CI in the case where we update pyproject.toml, such as this one:
#5538

In such a case, should we not run all the tests while turning off incremental testing?

That is, to ensure that estimators depending on the extra do not break, or detect that they break.

This could be achieved in two locations - GHA, or run_tests_for_class, adding one more conditional so it always defaults to True if the pyproject.toml has changed.

FYI @yarnabrina, @benHeid

@fkiraly fkiraly added module:tests test framework functionality - only framework, excl specific tests enhancement Adding new functionality labels Nov 8, 2023
@yarnabrina
Copy link
Collaborator

Makes sense (and I'll agree if you disable even sub-sampling). But it'll possibly lead to long duration in my opinion unless #5477 is solved.

@fkiraly
Copy link
Collaborator Author

fkiraly commented Nov 8, 2023

One could argue, the deps are so important so we should test really everything if they change - dep changes are, after all, relatively rare.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding new functionality module:tests test framework functionality - only framework, excl specific tests
Projects
None yet
Development

No branches or pull requests

2 participants