Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Identify modified extra(s) in PR's that modify pyproject.toml #5477

Open
yarnabrina opened this issue Oct 22, 2023 · 0 comments
Open
Labels
maintenance Continuous integration, unit testing & package distribution

Comments

@yarnabrina
Copy link
Collaborator

As part of #5375, a new CI workflow is introduced to validate extras. This works fine, but triggers a lot of jobs (135 = 9 extra × 5 python version × 3 operating systems) for ANY change in pyproject.toml.

It'd be nice to validate only modified extras instead of checking all, which is already being done as part of a scheduled workflow.

Desired behaviour:

  1. No job as part of this workflow if no component specific extras are modified.
  2. If one or more component specific extra gets modified, only those are detected. Then the validation works only for those and ignores rest.

Suggestions:

  1. Add a new job to read pyproject.toml file and detect the changes. This will output a JSON or similar output with true or false corresponding to each extra.
  2. The new job loops over this output and only modified ones get triggered.

This suggestion is along the lines of "Use change detection to configure matrix job" example from here. This is not necessarily the only way, and any improvements or completely different approaches are very much welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

No branches or pull requests

1 participant