New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge additional pydocstyle error fixes into development docs #1208
Conversation
Fix _fh.py docstrings
@mloning can you take a look at the changes in this and merge it into our development documentation branch if they look fine? Almost exclusively updates to pass |
great work @RNKuhns |
Fixed the merge conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @RNKuhns - looks all good to me
autodoc_default_options = { | ||
"members": True, | ||
"inherited-members": True, | ||
"member-order": "bysource", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is nice! so we should make sure fit
, predict
, transform
and update
are at the top in the code, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and also fixes docstrings in different places
I've merged this now @RNKuhns - wanted to look at a few other things based on your changes! |
Reference Issues/PRs
This partially addresses docstring updates needed to eventually implement #890.
What does this implement/fix? Explain your changes.
Primarily includes docstring fixes to pass
pydocstyle
checks that were needed because changes had to be made to some docstrings fornumpydoc
parsing.Also includes a couple tweaks to the look of the documentation pages.
Does your contribution introduce a new dependency? If yes, which one?
N/A. Just updates docstrings.
What should a reviewer concentrate their feedback on?
Any other comments?
PR checklist
For all contributions
For new estimators