New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error handling for get_tag
#1450
Merged
+69
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
found it, forgot the |
aiwalter
previously approved these changes
Sep 30, 2021
aiwalter
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the possibility to raise an error when
get_tag
is used.An error will always be raised if the function is used with parameter defaults and the tag with the specified
tag_name
does not exist, but this can be overridden by setting the newraise_error
parameter toFalse
.This should hopefully prevent the human error that caused the bug in #1449 for the future.
FYI @aiwalter, @thayeylolu, @mloning
This PR also contains a second test for
get_tag
to cover the behaviour ifraise_error=True
, the old test covers the behaviour ifraise_errpr=False
with minor changes.The change has caught the following bugs which are also fixed:
"enforce_index_type"
tag was sometimes written"enforce-index-type"
, this was changed to"enforce_index_type"
consistently"coerce-X-to-pandas"
was called in some classifiers but not set in the tine series classification base class