sktime clean clone method #1454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(happy to add tests if we decide to go with this solution) |
|
we don't need this, the problem this was trying to solve isn't actually one (cloning with dynamic tags works fine) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: This actually does not seem to have been a problem with #1449. We can keep using
sklearnclone.Will close once it is confirmed that we can fix #1449 without.
This PR adds a
clonemethod toBaseObject, which extendssklearnclone to deal with dynamic tags properly.This is one potential way to address the issue in #1449, in which behaviour controlling tags inside grid/random search estimators are not cloned properly, and lead to unexpected error messages when multivariate forecasters are cloned.
As a proof-of-concept, the
sklearnclone-s in the tuning module are also replaced by the newBaseObject.clone.An added advantage is our new ability to modify the behaviour of
clonein theBaseObject, in a modular fashion.