Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time series classifiers refactor/Shape_DTW #1554

Merged
merged 11 commits into from Oct 26, 2021

Conversation

Piyush1729
Copy link
Contributor

Reference Issues/PRs

Fixes a task of #1146 TSC refactor for ShapeDTW.

What does this implement/fix? Explain your changes.

Refactor ShapeDTW class according to the new extension template.
1.) fit, predict, and predict_proba turned private.
2.) Added _tags
3.) Removed unnecessary imports.
4.) removed input checks

Does your contribution introduce a new dependency? If yes, which one?

No

What should a reviewer concentrate their feedback on?

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors.
  • Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
  • I've added unit tests and made sure they pass locally.
For new estimators
  • I've added the estimator to the online documentation.
  • I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, looks good, but we have decided to not override the tags unless they are different to the base class values. You can basically remove the _tags all together for this class, since it has the default values

@TonyBagnall TonyBagnall added the module:classification classification module: time series classification label Oct 25, 2021
@Piyush1729
Copy link
Contributor Author

hi, looks good, but we have decided to not override the tags unless they are different to the base class values. You can basically remove the _tags all together for this class, since it has the default values

Done.

@Piyush1729
Copy link
Contributor Author

Piyush1729 commented Oct 25, 2021

Hi @TonyBagnall , @MatthewMiddlehurst forecasting/model_evaluation/tests/test_evaluate.py::test_evaluate_common_configs[scoring0-refit-1-7--3-ExpandingWindowSplitter]
Has failed, which is not relevant to any modification done in this PR.

@TonyBagnall
Copy link
Contributor

hi, this is I think an intermittent bug, nothing to do with your PR. If you trigger a rebuild it should go away!

@Piyush1729
Copy link
Contributor Author

Hi, is there a rebuild option without commiting again

@MatthewMiddlehurst
Copy link
Contributor

For the test that failed yes. I have set it to run again.

Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution

@TonyBagnall TonyBagnall merged commit 4e7ccb9 into sktime:main Oct 26, 2021
@fkiraly fkiraly mentioned this pull request Oct 29, 2021
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:classification classification module: time series classification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants