New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time series classifiers refactor/Shape_DTW #1554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi, looks good, but we have decided to not override the tags unless they are different to the base class values. You can basically remove the _tags all together for this class, since it has the default values
Done. |
Hi @TonyBagnall , @MatthewMiddlehurst forecasting/model_evaluation/tests/test_evaluate.py::test_evaluate_common_configs[scoring0-refit-1-7--3-ExpandingWindowSplitter] |
hi, this is I think an intermittent bug, nothing to do with your PR. If you trigger a rebuild it should go away! |
Hi, is there a rebuild option without commiting again |
For the test that failed yes. I have set it to run again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the contribution
Reference Issues/PRs
Fixes a task of #1146 TSC refactor for ShapeDTW.
What does this implement/fix? Explain your changes.
Refactor ShapeDTW class according to the new extension template.
1.) fit, predict, and predict_proba turned private.
2.) Added _tags
3.) Removed unnecessary imports.
4.) removed input checks
Does your contribution introduce a new dependency? If yes, which one?
No
What should a reviewer concentrate their feedback on?
Any other comments?
PR checklist
For all contributions
For new estimators