[BUG] dealing with sklearn 1.2 deprecation warnings and solving the first part #2190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes the first part of #2143 : replacing float variable names by str in pandas.DataFrame passed.
What does this implement/fix? Explain your changes.
I trace the warning and find out in summarize.py, quantiles are presented as "float" while other features are represented as "str", and that is the root of this warning. So I transform these float numbers to string.
Does your contribution introduce a new dependency? If yes, which one?
No.
What should a reviewer concentrate their feedback on?
All unit tests in 'classification' directory have passed. And here is the output:
For tests/test_all_estimators.py, here is the output:
There is no warning about "FutureWarning: Feature names only support names that are all strings. Got feature names with dtypes: ['float', 'str']. An error will be raised in 1.2."
Any other comments?
The above warnings need to be solved too.
PR checklist
For all contributions
For new estimators