[ENH] refactored ColumnConcatenator, rewrite using pd-multiindex inner type
#2379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
module:transformations
This reverts commit f54f352.
fkiraly
changed the title
ColumnConcatenator, rewrite using pd-multiindex inner type
fkiraly
added a commit
that referenced
this pull request
Jul 23, 2022
This fixes a recurring issue with duplicated indices from the time series classification datasets. This has been repeatedly breaking things downstream and made refactors difficult. Fixes #1290, fixes #2331 for the instance index, addresses the example in #1893 fixes the problem that prevents #2379 to be refactored. The fix makes changes in the `datasets` module that ensures unique index for loaded time series classification datasets, via `reset_index(drop=True)` Note: this does *not* prohibit duplicate time index, only duplicate instance name (index of the outer `DataFrame` in `nested_univ`).
fkiraly
added a commit
that referenced
this pull request
Jul 23, 2022
…nstance index in `sktime` datasets (#3029) This fixes a recurring issue with duplicated indices from the time series classification datasets. This has been repeatedly breaking things downstream and made refactors difficult. Fixes #1290, fixes #2331 for the instance index, addresses the example in #1893 fixes the problem that prevents #2379 to be refactored. Initial bug report about duplicate indices: #1290 Nature of the fix: * adds a check for `nested_univ` mtype that prohibits duplicate instance index * fixes an instance of duplicate indices in the benchmarking module * ensures that any `nested_univ` returns of the old `SeriesToSeriesRowTransformer` have unique instance index Note: this does *not* prohibit duplicate time index, only duplicate instance name (index of the outer `DataFrame` in `nested_univ`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a rewrite of the
ColumnConcatenator, usingpd-multiindex.Originally in #2369.
The conversion issues are fixed now, should all be good to go.
Relies on the fix to data loaders to ensure unique input index:
#3031
from first post:
Unfortunately, this has dredged up all kinds of issues with type casting and conversion, so I am isolating it to one PR and removing it from #2369.
The failures in this refactor are linked to the failures in the conversions here: #2375, since in the tests we make conversions between the nested data frame format and the
pd-multiindexformat.