[ENH] Fix tests to prevent guaranteed check_estimator failure
#2405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Done. |
fkiraly
approved these changes
Apr 7, 2022
fkiraly
changed the title
check_estimator failure
fkiraly
added a commit
that referenced
this pull request
Apr 9, 2022
This PR adds tests to test that tests conducted by the `check_estimator` utlity are passing, on three example estimators that are known to pass all tests in the full test suite. This ensures that future tests catch unintentional side effects to changes in the test module that cause a `check_estimator` test to fail, such as the problem addressed recently in #2405 Also turns some instances of `pytest.skip` inside tests into `return None`, as that currently breaks `check_estimator`. An issue to replace this workaroudn has been opened here: #2419
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous skip message led to an exception for debugging and was in alignment with @fkiraly instead replaced by None.